Don't send displayModel to "rendering" components on server side #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
fix_displaymodel
branch
from
17d691f
to
afe8e48
Compare
cmdcolin
force-pushed
the
fix_displaymodel
branch
from
afe8e48
to
be8089d
Compare
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, the displayModel was snapshotted and only 'selectedFeatureId' was sent to the backend. This was with the 'intent' to make the server side render the 'selected' feature border, or highlight.
However, this was found to result in hydration mismatch errors, so was removed, but displayModel is still forwarded to the server side. This changes it to nullify the displayModel attribute, and then corrects typescript attributes in the "rendering" components to make this more clear
this PR is made because the no-unnecessary-condition rule benefits from correct knowledge of the types