Fix configuration settings for track sorting in the track selector #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
fix_hier_sorting_config
branch
2 times, most recently
from
6f45b48
to
0f66a64
Compare
cmdcolin
force-pushed
the
fix_hier_sorting_config
branch
from
0f66a64
to
c4258fb
Compare
cmdcolin
force-pushed
the
fix_hier_sorting_config
branch
from
c4258fb
to
44c7af4
Compare
cmdcolin
force-pushed
the
fix_hier_sorting_config
branch
from
11d045b
to
d439bb2
Compare
cmdcolin
force-pushed
the
fix_hier_sorting_config
branch
from
d439bb2
to
0321f10
Compare
|
tried to make a variety of unit tests now that exercises the cases of "configuration supplied" and "localstorage supplied" settings |
cmdcolin
force-pushed
the
fix_hier_sorting_config
branch
from
69eaab3
to
ec52894
Compare
cmdcolin
force-pushed
the
fix_hier_sorting_config
branch
from
ec52894
to
146d930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in v2.11.1 changed the way sorting/collapsing was stored in the track selector, and makes it remember it across closing/re-opening the track selector, but broke the ability for admins to configure the sort behavior
This fixes that by making it so the fetching of the setting from the users localStorage becomes "undefined" rather than default false.