Fix sequence type choice displaying wrong info #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
codewise, the fix was mainly done by leaning the MST state more heavily instead of a mix of useState and MST state and using autorun to update the mode only when needed |
cmdcolin
force-pushed
the
store_sequence_featurestate_mst
branch
from
e737dd6
to
148ce6b
Compare
cmdcolin
force-pushed
the
store_sequence_featurestate_mst
branch
from
5a80f6a
to
f7c3231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "Open dialog" on the sequence feature panel changes the users mode choice (e.g. showing protein or cds sequence). This updates it to keep the state of the users choice
The choice can actually revert, and then display the wrong info
Seen on main branch, it says it is displaying protein, but is displaying CDS. this was only a bug added after #4448
