Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable dialog width in "About track" dialog for multi-quantitative tracks #4442

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

cmdcolin
Copy link
Collaborator

This particularly affects MultiQuantitativeTrack about dialog's because they use a data grid in their About track panel

A screen recording demonstrates the issue

Screen.Recording.2024-06-14.at.3.02.01.PM.mov

The width:100% that was there is likely vestigial from when older versions of x-data-grid needed a container to size into. That is not done automatically

@cmdcolin cmdcolin changed the title Fix unstable dialog width in about track when data grid is present Fix unstable dialog width in "About track" dialog for multi-quantitative tracks Jun 14, 2024
@cmdcolin cmdcolin merged commit 34e3a45 into main Jun 14, 2024
10 checks passed
@cmdcolin cmdcolin deleted the fix_weird_expansion_datagrid branch June 14, 2024 19:37
@cmdcolin cmdcolin added the bug Something isn't working label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant