Fix cursor:pointer style on an alignments feature detail clickable link #4438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that code in the alignment details widget (plugins/alignments/src/AlignmentsFeatureDetail/SuppAlignmentsLocStrings.tsx) had links with mouseover where the cursor did not use the pointer style, which turns out to be due to missing href prop on the Link element. For Link elements without a true href (e.g. they are more link link buttons), we can use href="#" and then event.preventDefault in the handler.
The alternative is not having any href and then using the makeStyles to restore the cursor:pointer style, but i think the href="#" is a bit more idiomatic. Just gotta remember to event.preventDefault in those cases.