Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message shown on chromosomes with missing data for plaintext GFF3 #4417

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 4, 2024

Small typescript issue related to undefined result of record data access

related to my typescript rant/blogpost https://cmdcolin.github.io/posts/2023-09-27-areyousure

We could consider turning on noUncheckedIndexedAccess tsc setting to try to help this more or less globally...but this just targets the smaller fix

Regression after #4406

@cmdcolin cmdcolin merged commit 286aa90 into main Jun 4, 2024
10 checks passed
@cmdcolin cmdcolin deleted the chr_empty_gff branch June 4, 2024 16:43
@cmdcolin cmdcolin added the bug Something isn't working label Jun 17, 2024
@cmdcolin cmdcolin changed the title Fix bug parsing GFF3 data on chromosomes where data is empty Fix error message shown on chromosomes with missing data for plaintext GFF3 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant