Remove node-polyfill-webpack-plugin #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
remove_nodepolyfillwebpackplugin
branch
from
19eecf1
to
72448ad
Compare
cmdcolin
force-pushed
the
remove_nodepolyfillwebpackplugin
branch
from
72448ad
to
24106bd
Compare
cmdcolin
added
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of NodePolyfillWebpackPlugin which is used in
The node-polyfill-webpack-plugin is used to polyfill Buffer amongst other things however i think it's a little bit backwards looking: most of our code works now without a lot of polyfilling, except for Buffer. I think removing it makes it more clear what needs polyfills, and that is basically just buffer.
Secondary to this PR, it can be removed from demos if possible
https://github.com/GMOD/jbrowse-react-linear-genome-view-cra5-demo/blob/main/craco.config.js
It might be that a specific line that polyfills Buffer might be needed, but I found our code actually works even without it (which i am not sure how the buffer code is working without that polyfill, may need investigating)