-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow viewing coordinates in sequence feature display panel #4399
Conversation
|
thanks for the review again...some updates
I added a new 'Download plaintext' and 'Download HTML' buttons to the dropdown menu now. I avoided the term "Download FASTA" because that only applies when the "show coordinates" options are off (since adding coordinates makes it non-FASTA format, and i think it matches user expectation to just get exactly what they are seeing in the panel)
I moved the show coordinates option again out of the Settings dialog into the dropdown menu and now made it "reactive" to the current sequence mode selected (e.g. Genomic, CDS, Protein) so that it only shows the "Relative to genome" option when the user has a non-discontinuous feature type selected. note: this option could, in principle, stay in the Settings dialog, but it seems like it is a good thing to me to allow 'one-click' changing of the show coordinates display mode via the dropdown instead of launch settings dialog->change setting->resume
Similar to above, only visible now for non-discontinuous feature types that support this option now
Did a little refactoring so that now the code for the menu is reusable in the dialog and non-dialog modes, so should be fixed now :) |
<span>
per line with this PRAddresses most of #3873 and incorporates work from https://github.com/GMOD/jbrowse-components/pull/4378/files