Add ability to get refNames for a track in the "About track" panel #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
get_refname_tracks
branch
2 times, most recently
from
2a1dfcf
to
71e4c9c
Compare
|
actually changed it so it is visible always, because the UI behavior for it being conditionally hidden, determined by a button at the top of the panel, doesn't work well for lengthy about panels |
cmdcolin
force-pushed
the
get_refname_tracks
branch
from
71e4c9c
to
a8bce7a
Compare
|
updated so that it is a separate dialog 
|
cmdcolin
force-pushed
the
get_refname_tracks
branch
from
0b4f58e
to
5621fe5
Compare
cmdcolin
force-pushed
the
get_refname_tracks
branch
from
5621fe5
to
55de2d1
Compare
|
I now make it so that there is a "show refnames" button that pops up a new dialog. This avoids the issue of the extra panel being too low and off-screen which was my on-going concern with this PR
this PR does not attempt to automatically show the user if their track is blank, but provides an avenue where they can potentially debug without resorting to misc command line tools |
cmdcolin
force-pushed
the
get_refname_tracks
branch
from
2e54bb5
to
0c564c9
Compare
cmdcolin
force-pushed
the
get_refname_tracks
branch
from
0c564c9
to
08e8806
Compare
|
this now works on synteny adapters, where it actually requires the assembly name to be passed to the getRefNames function |
cmdcolin
force-pushed
the
get_refname_tracks
branch
from
08e8806
to
1021683
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example proposal
The ref name panel is hidden by default, but can optionally be shown by clicking the "Show ref names" button. It may help address cases where users have "blank" tracks...we can instruct users to investigate the about track panel