Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned features under breakpoint split view #2852

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 24, 2022

Without this PR
localhost_3000__config=test_data%2Fbreakpoint%2Fconfig json session=local-cSgT1q9-w (1)

With this PR
localhost_3000__config=test_data%2Fbreakpoint%2Fconfig json session=local-cSgT1q9-w

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 24, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #2852 (04494a2) into main (85973e5) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2852      +/-   ##
==========================================
- Coverage   59.83%   59.81%   -0.03%     
==========================================
  Files         584      584              
  Lines       26562    26562              
  Branches     6448     6448              
==========================================
- Hits        15894    15888       -6     
- Misses      10354    10360       +6     
  Partials      314      314              
Impacted Files Coverage Δ
...src/LinearGenomeView/components/TrackContainer.tsx 87.17% <ø> (ø)
plugins/breakpoint-split-view/src/util.ts 100.00% <100.00%> (ø)
packages/core/TextSearch/TextSearchManager.ts 96.55% <0.00%> (-3.45%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 77.77% <0.00%> (-3.04%) ⬇️
packages/core/util/analytics.ts 89.79% <0.00%> (-2.05%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 85.10% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85973e5...04494a2. Read the comment docs.

@cmdcolin cmdcolin merged commit 87d8b26 into main Mar 25, 2022
@cmdcolin cmdcolin deleted the improved_breakpoint_split_view branch March 25, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant