Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to color all the letters on all the reads to the pileup renderer #2847

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 23, 2022

Draw all bases in the pileup with a setting called "Per-base lettering" (alongside the "Per-base quality")

It is a nice sanity check for alignments viewing

localhost_3000__config=test_data%2Fconfig_new%2Fconfig json session=local-CZUoNOgc8 (1)

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #2847 (f13ee8f) into main (9dba0d9) will decrease coverage by 0.08%.
The diff coverage is 10.86%.

@@            Coverage Diff             @@
##             main    #2847      +/-   ##
==========================================
- Coverage   59.89%   59.80%   -0.09%     
==========================================
  Files         584      584              
  Lines       26528    26561      +33     
  Branches     6443     6446       +3     
==========================================
- Hits        15888    15884       -4     
- Misses      10326    10363      +37     
  Partials      314      314              
Impacted Files Coverage Δ
...lugins/alignments/src/LinearPileupDisplay/model.ts 63.45% <0.00%> (-0.66%) ⬇️
...s/alignments/src/PileupRenderer/PileupRenderer.tsx 48.37% <4.87%> (-3.80%) ⬇️
.../src/LinearPileupDisplay/components/ColorByTag.tsx 100.00% <100.00%> (ø)
...iew/src/LinearGenomeView/components/CenterLine.tsx 91.66% <0.00%> (-8.34%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dba0d9...f13ee8f. Read the comment docs.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 23, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 23, 2022
@cmdcolin cmdcolin merged commit 85973e5 into main Mar 23, 2022
@cmdcolin cmdcolin deleted the per_base_coloring branch March 24, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant