Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change calculation for number of webworkers for web/desktop #2828

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

cmdcolin
Copy link
Collaborator

Currently the formula for getting number of web workers is a bit odd. (#cores -2) /3. probably an ad-hoc formula

On my machine it produces 5 workers (16 cores-2/3 = 4.666 Math.ceil to 5)

I think 5 on my machine with many cores is reasonable, if it used a lot more it would probably go too crazy (its a laptop...fans would take off)

But, on a 4 core AWS instance doing profiling tests, it is only getting 1 worker thread. I think maxing out hardware cores -1 for jbrowse, with a cap on 5 cpu's, could be a reasonable change to the formula

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #2828 (2f1747f) into main (1d6e373) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2f1747f differs from pull request most recent head ba8b499. Consider uploading reports for the commit ba8b499 to get more accurate results

@@           Coverage Diff           @@
##             main    #2828   +/-   ##
=======================================
  Coverage   59.98%   59.99%           
=======================================
  Files         584      584           
  Lines       26613    26688   +75     
  Branches     6459     6462    +3     
=======================================
+ Hits        15964    16011   +47     
- Misses      10335    10349   +14     
- Partials      314      328   +14     
Impacted Files Coverage Δ
packages/core/rpc/BaseRpcDriver.ts 84.76% <100.00%> (ø)
...g/src/SvgFeatureRenderer/components/SvgOverlay.tsx 46.57% <0.00%> (-0.73%) ⬇️
packages/core/util/simpleFeature.ts 84.90% <0.00%> (ø)
...FeatureRenderer/components/ProcessedTranscript.tsx
...ns/svg/src/SvgFeatureRenderer/components/Arrow.tsx
...svg/src/SvgFeatureRenderer/components/Segments.tsx
...FeatureRenderer/components/SvgFeatureRendering.tsx
...gins/svg/src/SvgFeatureRenderer/components/Box.tsx
.../src/SvgFeatureRenderer/components/Subfeatures.tsx
...src/SvgFeatureRenderer/components/FeatureGlyph.tsx
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a20af...ba8b499. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 18, 2022
@cmdcolin cmdcolin merged commit f8528c7 into main Mar 18, 2022
@cmdcolin cmdcolin deleted the maximize_utilization branch March 18, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants