Change calculation for number of webworkers for web/desktop #2828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the formula for getting number of web workers is a bit odd. (#cores -2) /3. probably an ad-hoc formula
On my machine it produces 5 workers (16 cores-2/3 = 4.666 Math.ceil to 5)
I think 5 on my machine with many cores is reasonable, if it used a lot more it would probably go too crazy (its a laptop...fans would take off)
But, on a 4 core AWS instance doing profiling tests, it is only getting 1 worker thread. I think maxing out hardware cores -1 for jbrowse, with a cap on 5 cpu's, could be a reasonable change to the formula