Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimization for BAM and unzip operations #2820

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

Bumps @gmod/bgzf-filehandle for fix in GMOD/bgzf-filehandle#57

Was found to have a 5.5x performance improvement in a particular short read example with high coverage reads

@cmdcolin cmdcolin changed the title Add optimization for BAM unzip operations Add optimization for BAM and unzip operations Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2820 (131b640) into main (c72cea5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2820      +/-   ##
==========================================
- Coverage   59.98%   59.98%   -0.01%     
==========================================
  Files         584      584              
  Lines       26690    26690              
  Branches     6463     6463              
==========================================
- Hits        16010    16009       -1     
- Misses      10350    10351       +1     
  Partials      330      330              
Impacted Files Coverage Δ
...ckages/core/pluggableElementTypes/RpcMethodType.ts 83.33% <0.00%> (-2.09%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72cea5...131b640. Read the comment docs.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 16, 2022
@cmdcolin cmdcolin added enhancement New feature or request performance and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 16, 2022
@cmdcolin cmdcolin merged commit 4ad5d56 into main Mar 16, 2022
@cmdcolin cmdcolin deleted the bgzf_optimization branch March 16, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant