Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filtering display type from core #2232

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

cmdcolin
Copy link
Collaborator

Fixes #2209 by removing the filtering plugin from core

We could try to maintain this plugin but I think it may be better to remove from core for now

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Aug 19, 2021
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #2232 (18f93f7) into main (f33c9e7) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
+ Coverage   62.93%   63.14%   +0.20%     
==========================================
  Files         484      479       -5     
  Lines       22720    22616     -104     
  Branches     5154     5143      -11     
==========================================
- Hits        14298    14280      -18     
+ Misses       8152     8072      -80     
+ Partials      270      264       -6     
Impacted Files Coverage Δ
products/jbrowse-desktop/src/corePlugins.ts 100.00% <ø> (ø)
products/jbrowse-web/src/corePlugins.ts 100.00% <ø> (ø)
packages/core/util/io/rangeFetcher.ts 90.24% <0.00%> (-2.44%) ⬇️
packages/core/assemblyManager/assemblyManager.ts 60.00% <0.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33c9e7...18f93f7. Read the comment docs.

@cmdcolin cmdcolin requested a review from rbuels August 20, 2021 19:18
@rbuels rbuels merged commit 6465b8d into main Aug 23, 2021
@rbuels rbuels deleted the remove_filtering_default branch August 23, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinearFilteringTrack demo on volvox has error
2 participants