Make the BED parser not interpret general tab delimited data as BED12 #2199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
bed_parser_unassuming
branch
from
a0ddfac
to
9365d3a
Compare
cmdcolin
changed the title
|
Change added to @gmod/bed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current @gmod/bed parser makes I think too assumptions about what a BED file is if no info is specified e.g. as with BED tabix files.
For example, currently the inversion BED tabix files in #2198 are displayed incorrectly (it thinks it is an intron because it thinks it's like a BED12 file)
This proposes using an "unassuming" BED parser that will use the strand/score fields if it makes sense to, otherwise it just stores the fieldnames, and only tries to use @gmod/bed if the code is actually a BED12 file or has autoSql attached
With this change added, the BED tabix files in #2198 display properly e.g. just as boxes indicating the region of the inversion, and some fields that don't have any description are called field5,field6,field7... in the feature details panel