Fix handle leak for killed worker checker #2197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for checking if a worker was killed would progressively create more watchers over time because the resolve was never called. I mistakenly thought that Promise.race might kill the watcher promise
This was found because I saw the code freeze, and clicking the pause tab in the source debugger always ended up at the worker=='killed' line which seemed odd, and console.logging around this line indicated that it could be called thousands of times a second