Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish desktop builds #2029

Merged
merged 82 commits into from
Aug 9, 2021
Merged

Polish desktop builds #2029

merged 82 commits into from
Aug 9, 2021

Conversation

elliothershberg
Copy link
Member

@elliothershberg elliothershberg commented Jun 1, 2021

This PR works on completing tasks described in #2020 . (Closes #2020 )

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 1, 2021
@elliothershberg elliothershberg added the enhancement New feature or request label Jun 1, 2021
@elliothershberg elliothershberg self-assigned this Jun 1, 2021
@elliothershberg elliothershberg removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #2029 (e63577f) into main (ba45e95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2029   +/-   ##
=======================================
  Coverage   62.71%   62.71%           
=======================================
  Files         484      484           
  Lines       22641    22641           
  Branches     5141     5141           
=======================================
  Hits        14200    14200           
  Misses       8171     8171           
  Partials      270      270           
Impacted Files Coverage Δ
packages/core/util/index.ts 79.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba45e95...e63577f. Read the comment docs.

@elliothershberg elliothershberg marked this pull request as ready for review August 6, 2021 16:27
@cmdcolin
Copy link
Collaborator

cmdcolin commented Aug 6, 2021

ooo...beta https://github.com/GMOD/jbrowse-components/releases/tag/untagged-9bfdb7142cdef46ca909

@elliothershberg
Copy link
Member Author

Yuppp! I think things are set up to do a desktop beta whenever we feel ready...

@rbuels
Copy link
Contributor

rbuels commented Aug 6, 2021

This looks great, how does it decide whether to do a beta or a full release though? Does it know how to do a full release?

@elliothershberg
Copy link
Member Author

This currently is set up for the beta release process:

- name: Create Release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ env.RELEASE_VERSION }}
release_name: Release desktop ${{ env.RELEASE_VERSION }}
draft: true
prerelease: true

It creates a draft release that has prerelease: true.

Ultimately, this workflow run can probably be removed, and when we are doing full desktop releases as a part of our release cycle, electron-builder should be able to detect our main draft and upload the artifacts there.

@rbuels rbuels merged commit ba12c74 into main Aug 9, 2021
@rbuels rbuels deleted the 2020_desktop_builds branch August 9, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish desktop builds for release
3 participants