Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hydrometeors #422

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add hydrometeors #422

wants to merge 3 commits into from

Conversation

rtodling
Copy link
Contributor

@rtodling rtodling commented Sep 12, 2024

Description

This adds hydrometeors and changes to the linear obs operators necessary to account for sensitivity of all-sky MW to such fields.

Dependencies

  • [https://github.com/JCSDA-internal/fv3-jedi/pull/1257 ] waiting on fv3-jedi
  • [ https://github.com/JCSDA-internal/saber/pull/939] waiting on saber

Impact

Enhanced features and corrections and consistency w/ GSI

Issues

[#418] this is associated w/ the issue marked here.

@rtodling
Copy link
Contributor Author

Look around to try to understand some - unrelated to this - I came across the fact that by default, the hydrometeors radii is set to use GFDL's numbers ... the GSI numbers are an option ... The yaml's for GMI and AMRS2 in swell are using the fv3-jedi default which is not what we want - I believe.

I ran a little test w/ GMI obs only to see what difference we get from these two schemes in comparison to GSI: I find that the difference between the two schemes is considerable smaller than the difference of either scheme w/ the actual GSI. Here is an illustration of the differences: top: GSI-minus-fv3-jedi using GSI radii; bottom: diff of JEDI increments when using either GSI or GFDF radii ...

qr_radii_schemes

The differences in the temperature are unnoticeable either way - GSI and JEDI are quite good match to each other regardless of which scheme is used - no need to show.

In any case, the consistent choice of radii is also being introduced in the changes presented here.

@rtodling rtodling marked this pull request as ready for review September 25, 2024 16:13
@rtodling
Copy link
Contributor Author

The PRs from JEDI mentioned above have been merged. I believe the changes here could now make it into SWELL

@rtodling rtodling added the enhancement New feature or request label Sep 25, 2024
@Dooruk
Copy link
Collaborator

Dooruk commented Sep 25, 2024

@rtodling Can you set the environment LOG_INFO variable to 1 and run swell test code_tests with this branch please? There is a code testing issue.

https://geos-esm.github.io/swell/#/code_tests/code_tests

@Dooruk
Copy link
Collaborator

Dooruk commented Sep 25, 2024

This will be on-hold until a JEDI build post ~September 20th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants