Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up for #3231 #3245

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Follow up for #3231 #3245

merged 3 commits into from
Dec 12, 2024

Conversation

pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Dec 11, 2024 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Follow up for PR #3231

  • ConfigurableGridComp - cleanup
  • Bug fix - BasicVerticalGrid::can_connect_to fails if dst id is different from this id

Related Issue

@pchakraborty pchakraborty added 🪲 Bug Something isn't working 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Dec 11, 2024
@pchakraborty pchakraborty self-assigned this Dec 11, 2024
@pchakraborty pchakraborty requested a review from a team as a code owner December 11, 2024 22:55
@tclune tclune merged commit 0d4ae10 into release/MAPL-v3 Dec 12, 2024
39 checks passed
@tclune tclune deleted the feature/pchakrab/update-configurable-gridcomp-follow-up branch December 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@pchakraborty pchakraborty

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🪲 Bug Something isn't working Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pchakraborty @tclune