Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3215 Use ESMF_FieldEmptyReset() #3216

Open
wants to merge 2 commits into
base: release/MAPL-v3
Choose a base branch
from
Open

Fixes #3215 Use ESMF_FieldEmptyReset() #3216

wants to merge 2 commits into from

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Dec 4, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Switch to using new ESMF_FieldEmptyReset(). Cannot merge until ESMF has been updated in all relevant environments. (CI and MAPL3 developer laptops)

Related Issue

@tclune tclune added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Dec 4, 2024
@tclune tclune requested a review from a team as a code owner December 4, 2024 14:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

This PR is being prevented from merging because you have added one of our blocking labels: 🚫 Contingent - DNA. You'll need to remove it before this PR can be merged.

@mathomp4
Copy link
Member

mathomp4 commented Dec 4, 2024

I've added a CMake requirement for ESMF 8.8 as that is where this feature will be from. CI will still fail, just probably fail faster since CMake will now die instead of the compile step

darianboggs
darianboggs approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@darianboggs darianboggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darianboggs darianboggs darianboggs approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tclune @mathomp4 @darianboggs