Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wdboggs/change extension action methods 3108 #3112

Open
wants to merge 6 commits into
base: release/MAPL-v3
Choose a base branch
from

Conversation

darianboggs
Copy link
Contributor

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Change run to update and invalidate method for ExtensionAction.

Related Issue

Closes issue #3108

@darianboggs darianboggs added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related labels Oct 18, 2024
@darianboggs darianboggs self-assigned this Oct 18, 2024
@darianboggs darianboggs requested a review from a team as a code owner October 18, 2024 22:03
@darianboggs
Copy link
Contributor Author

Since I added invalidate method to ExtensionAction, all the types derived from it need an invalidate method also. Rather than add an no-op method to each of the extended types, I added a no-op invalidate method to the abstract type. Extended types can overload the method as needed. If we want the abstract type to have only deferred methods, we could create a "base" or "implementation" abstract type extended from ExtensionAction that the current extended types would extend instead. Open to suggestions.

@darianboggs
Copy link
Contributor Author

ifort is compiling. gfortran is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant