Fixes #3075 - propagate time-varying aspects of fields #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required updating various things to use new MAPL_Info interfaces. Need to be careful that keys sent to ESMF do not end in "/" and yet we don't want users to have to prepend their keys with "/". Fix for now is to check and prepend with "/" if not present. If performance is found to be inadequate the issue will be revisited.
tclune
added
🎁 New Feature
|
CI is weird. Seems like a Github problem. I'll re-run |
Probably not the issue. I keep forgetting to run the cap tests that also exercise the generic layer. So my bad for pushing before all tests at least pass in my development environment. But - now that I want to build on this, I'm going to use SU to get it into the code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required updating various things to use new MAPL_Info interfaces.
Need to be careful that keys sent to ESMF do not end in "/" and yet we don't want users to have to prepend their keys with "/". Fix for now is to check and prepend with "/" if not present.
If performance is found to be inadequate the issue will be revisited.
Types of change(s)
Checklist
make tests)Description
Related Issue