Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #903 #904

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fixes #903 #904

merged 1 commit into from
Feb 20, 2024

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Feb 16, 2024

Fixes #903
The single column model does not work (and probably never has) in the debug build. This is just clear bug, you can't connect two variables with different vertical specs as detailed in the issue.
This is probably non-zero diff for the single column model that was a flat out bug in the single column before.

@bena-nasa bena-nasa added bug Something isn't working bugfix This fixes a bug labels Feb 16, 2024
@bena-nasa bena-nasa requested a review from a team as a code owner February 16, 2024 19:42
@bena-nasa bena-nasa added Non 0-diff The changes in this pull request are non-zero-diff 0 diff The changes in this pull request have verified to be zero-diff with the target branch. and removed Non 0-diff The changes in this pull request are non-zero-diff labels Feb 16, 2024
@mathomp4 mathomp4 merged commit 07f7c5a into develop Feb 20, 2024
18 of 21 checks passed
@mathomp4 mathomp4 deleted the feature/bmauer/fixes-#903 branch February 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bug Something isn't working bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OMEGA in Datmodyn not defined consistently with rest of model. Causes SCM failure in DEBUG build.
3 participants