Add zlib-ng 2.1.6, remove zlib #75
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
changed the title
Closed
# Conflicts: # .gitmodules # CHANGELOG.md # GNUmakefile # README.md # zlib
mathomp4
changed the title
|
This fails on macOS. Or, rather, it builds just fine on macOS, but nothing can link to it. For example with curl: and from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
This PR moves ESMA-Baselibs from zlib (which is stable, but might have issues with newer hardware, etc.) to zlib-ng which is an actively maintained and developed library which seems to provide better performance.
Tests show this is zero-diff for GEOS. It all runs just fine.
Only tested on discover. Need to test on macOS.