Infoj Order Correction

[RobAndrewHurst]

Description

The lookup for the infoj_order checks on key, then field, and finally query. This fails when a key exists but doesn't match.

We have created a set of the different fields that will then be compared with a has check on the entry.

GitHub Issue

Type of Change

Please delete options that are not relevant, and select all options that apply.

• ✅ Bug fix (non-breaking change which fixes an issue)
• ✅ Testing

How have you tested this?

Run the local tests.

Testing Checklist

• ✅ Existing Tests still pass
• ✅ New Tests Added
• ✅ Ran locally on my machine

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1208407306090525

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[dbauszus-glx]

Looking good.

I moved the map method into documented function to make this eassier readable.

I updated the test to be in order of infoj > order > execution > results > expected > test for readability especially when setting breakpoints.

Note that you can create an array from an elements list allowing to use map functions instead of pushing into results in a for loop.

      const results = Array.from(infoj.children)
        .map(el => el.firstChild.innerText.trim())

[AlexanderGeere]

lgtm

[RobAndrewHurst]

Looking good.

I moved the map method into documented function to make this eassier readable.

I updated the test to be in order of infoj > order > execution > results > expected > test for readability especially when setting breakpoints.

Note that you can create an array from an elements list allowing to use map functions instead of pushing into results in a for loop.

      const results = Array.from(infoj.children)
        .map(el => el.firstChild.innerText.trim())

Nice one!