Pass filter to minmax #1501
Merged
Pass filter to minmax #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-leech
requested review from
cityremade,
dbauszus-glx,
AlexanderGeere and
RobAndrewHurst
simon-leech
added
Bug
|
| @@ -67,5 +67,22 @@ export async function filtersTest(mapview) { | |||
| codi.assertEqual(minInput.value, '100', 'The min should return 100.'); | |||
| codi.assertEqual(maxInput.value, '1000', 'The max should return 1000'); | |||
| }); | |||
|
|
|||
| await codi.it('Numeric Filter: layer.current specified as `lte: 200` and `gte: 800`', async () => { | |||
There was a problem hiding this comment.
Nice one! Thanks :)
AlexanderGeere
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass Filter to minmax
Description
I noticed that the default
field_minmaxquery containsWHERE TRUE ${filter}, however we never pass thefilteras a parameter into the query.So the layer filter is never being used in this query.
This is a bug as we need to ensure the filtering occurs only on the data used on the layer itself, not on all data on the table on the database.
I have resolved this by simply adding it to the list of parameters passed to the query.
Type of Change
Please delete options that are not relevant, and select all options that apply.
Testing Checklist
Please delete options that are not relevant, and select all options that apply.
Code Quality Checklist
Please delete options that are not relevant, and select all options that apply.