Location mock #1453
Merged
Location mock #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobAndrewHurst
added
Feature
RobAndrewHurst
requested review from
dbauszus-glx,
AlexanderGeere and
simon-leech
simon-leech
approved these changes
Sep 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need the ability to pass in a custom template to the location.get() function. This can be used in different use cases. The main one at the moment is used to mock locations in the testing environment.
Type of Change
Please delete options that are not relevant, and select all options that apply.
How have you tested this?
Run the local tests and Look for the location: getTest.
Testing Checklist
Note that the user tests will fail with a public instance. This is something that still needs to be resolved by spoofing a user.