Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add src test method to workspace module. #1432

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Add src test method to workspace module. #1432

merged 6 commits into from
Sep 3, 2024

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Aug 22, 2024 •
edited
Loading

The test method will cache the workspace, get every locale, and every template.

The template error logged by the getTemplate method are returned with the HTTP response.

image

@dbauszus-glx dbauszus-glx linked an issue Aug 22, 2024 that may be closed by this pull request
workspace api /test src string sources #1430
Closed
@dbauszus-glx dbauszus-glx added the Feature New feature requests or changes to the behaviour or look of existing application features. label Sep 2, 2024
@dbauszus-glx dbauszus-glx marked this pull request as ready for review September 2, 2024 14:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

simon-leech
simon-leech approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new test to the test_view that will call this method and return all invalid paths as errors.

All working for me :)

@RobAndrewHurst RobAndrewHurst merged commit a6c4aaa into GEOLYTIX:main Sep 3, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the workspace-src-test branch September 30, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobAndrewHurst RobAndrewHurst RobAndrewHurst approved these changes

@simon-leech simon-leech simon-leech approved these changes

@cityremade cityremade Awaiting requested review from cityremade

@AlexanderGeere AlexanderGeere Awaiting requested review from AlexanderGeere

Assignees

@RobAndrewHurst RobAndrewHurst

Labels
Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace api /test src string sources
3 participants
@dbauszus-glx @RobAndrewHurst @simon-leech