Fix language differences #1429
Merged
Fix language differences #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobAndrewHurst
added
the
Bug
RobAndrewHurst
requested review from
cityremade,
dbauszus-glx,
AlexanderGeere and
simon-leech
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a discrepancy between Spanish, Chinese Simplified and Traditional keys being used in the different dictionary objects being used throughout the application. Please make sure that if you add a language that there are base keys, and if there is already a language defined that you are using the correct key.
e.g of issue
Spanish base key = esp
In other modules = es
Type of Change
How have you tested this?
You can test this by running the local tests and you should see the dictionary tests pass.