entry without node in valChangeMethod on a new location. #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
the
Bug
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
simon-leech
approved these changes
Aug 21, 2024
|
This looks all good to me. I just want to write a test for the module first and then it can go in. |
|
|
This is quite complex to test the location view. I will need more time to write a test for this. |
RobAndrewHurst
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new location is immediately editable.
The valChange method called to check values in a new location will fail because the entry.node is undefined.