Do not assign window as caller for vector layer reload method #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
the
Bug
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
simon-leech
requested changes
Aug 12, 2024
lib/layer/format/vector.mjs
Outdated
simon-leech
reviewed
Aug 12, 2024
tests/workspace.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "locale": { | |||
| "plugins": [ | |||
| "${PLUGINS}v4.8.0/coordinates.js" | |||
| "${PLUGINS}/v4.8.0/coordinates.js" | |||
There was a problem hiding this comment.
Does this need to change in this PR?
Isn't this in line with the xyz_settings?
There was a problem hiding this comment.
No it doesn't need to change in this PR. In fact there should be an issue to review whether a workspace with private variables should be in the repository.
|
simon-leech
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling a bound method like this from a [window] setTimeout() method assigns the window as this.