zero config bug and secret #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
dbauszus-glx
added
the
Bug
|
In draft until I get to show a dialog with the note that no locale is available. |
|
A dialog is shown if no layers are available. The modal-map css has been fixed to include z-index and set the top, left + translate.
|
RobAndrewHurst
approved these changes
Jul 9, 2024
|
@RobAndrewHurst this should only be temporary as these are to be replaced with modal dialogs in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth module must return null if no environment secret is defined in the environment.
The workspace cache variable should not crash if the WORKSPACE env is not defined.
An empty default view should open without crashing the process.