Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entry type:key to return layer display toggle #1315

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Jun 11, 2024

This PR has a few changes -

  1. Moved key and title to their own .mjs files and added documentation for them.
  2. Updated _entries.mjs to reflect change in 1.
  3. Updated the key to become a button that enables the user to press it to toggle display of the layer. This has a button title of the mapp dictionary toggle visibility label.

This addresses issue #1314

@simon-leech simon-leech linked an issue Jun 11, 2024 that may be closed by this pull request
@simon-leech simon-leech added Feature New feature requests or changes to the behaviour or look of existing application features. CSS Changes in stylesheets labels Jun 11, 2024
@simon-leech simon-leech marked this pull request as ready for review June 12, 2024 08:09
@dbauszus-glx dbauszus-glx changed the title Type Key Changes entry type:key to return layer display toggle Jun 12, 2024
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Though a button should always reflect it's state.

This will also make the toggle condition in the onclick event much clearer.

Screencast.from.12-06-24.17.58.30.webm

Copy link
Contributor

@AlexanderGeere AlexanderGeere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, Good Docs!

@RobAndrewHurst RobAndrewHurst merged commit ccaf9ac into GEOLYTIX:main Jun 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Changes in stylesheets Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infoj Entry Type Key > Toggleable Layer Button
5 participants