-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entry type:key to return layer display toggle #1315
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Though a button should always reflect it's state.
This will also make the toggle condition in the onclick event much clearer.
Screencast.from.12-06-24.17.58.30.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, Good Docs!
This PR has a few changes -
key
andtitle
to their own.mjs
files and added documentation for them._entries.mjs
to reflect change in 1.key
to become a button that enables the user to press it to toggle display of the layer. This has a button title of the mapp dictionary toggle visibility label.This addresses issue #1314