Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapp.ui.elements.pills Documentation and Rename 👀 #1266

Merged
merged 3 commits into from
May 21, 2024

Conversation

RobAndrewHurst
Copy link
Contributor

mapp.ui.elements.pill Documentation and Rename 👀

  • ✍️ Renamed pillComponent.mjs -> pill.mjs to fit in with the current naming conventions.

  • ✍️ Corrected the pill.mjs documentation so that the module page will be produced from the generate process.

    • The @module tag and the @function tag need to be in separate comment blocks for JSDoc 📖

@RobAndrewHurst RobAndrewHurst added the Code Issues related to the code structure and performance. label May 21, 2024
@RobAndrewHurst RobAndrewHurst self-assigned this May 21, 2024
@RobAndrewHurst RobAndrewHurst changed the title **mapp.ui.elements.pill** Documentation and Rename 👀 mapp.ui.elements.pill Documentation and Rename 👀 May 21, 2024
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on naming but it should be pills as a pill [singular] is a class that makes up the pills element/entry.

@RobAndrewHurst RobAndrewHurst changed the title mapp.ui.elements.pill Documentation and Rename 👀 mapp.ui.elements.pills Documentation and Rename 👀 May 21, 2024
@RobAndrewHurst RobAndrewHurst merged commit 4ae5637 into GEOLYTIX:main May 21, 2024
5 checks passed
@RobAndrewHurst RobAndrewHurst deleted the pill_docs branch May 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants