Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvt_clone - reduce instances where the layer has to be removed or added. #1265

Merged
merged 3 commits into from
May 22, 2024

Conversation

dbauszus-glx
Copy link
Member

Only the show() / hide() methods should require the layer L to be added or removed from the mapview.

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label May 20, 2024
@dbauszus-glx dbauszus-glx marked this pull request as ready for review May 21, 2024 09:27
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@simon-leech simon-leech changed the title reduce instances where the layer has to be removed or added. mvt_clone - reduce instances where the layer has to be removed or added. May 22, 2024
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working as expected for me and resolves the few bugs found

@RobAndrewHurst RobAndrewHurst merged commit c80aa89 into GEOLYTIX:main May 22, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the mvt_clone_chkzoom branch September 9, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants