Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbcparser: fix byte order values #30

Closed
wants to merge 2 commits into from
Closed

dbcparser: fix byte order values #30

wants to merge 2 commits into from

Conversation

mguentner
Copy link
Contributor

@mguentner
dbcparser: fix byte order values
e83c09f 
0: little_endian, Intel
1: big_endian, Motorola
@mguentner
Copy link
Contributor Author

Should also fix GENIVI/CANdevStudio#200

@mguentner
Copy link
Contributor Author

Please forget this PR.

As already stated in GENIVI/CANdevStudio#202, the PDF that says

byte_order = '0' | '1' ; (* 0=little endian, 1=big endian *)

is wrong!

The correct values are

byte_order = '0' | '1' ; (* 0=big endian, 1=little endian *)

So the line that this PR intended to change is actually correct!

@mguentner mguentner closed this Aug 2, 2020
@mguentner mguentner deleted the fix_byte_order branch August 2, 2020 17:55
@jenszo
Copy link
Contributor

jenszo commented Aug 2, 2020

Can confirm the current behaviour is correct.

@mguentner
Copy link
Contributor Author

Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

litter endian and big endian error
2 participants
@mguentner @jenszo