Fix several issues with the dbc parser #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this file has been copied 1:1 from https://github.com/ANCIT/pythoncan-examples/blob/master/python-can-examples/resources/comfort.dbc and is licensed under the EPL 2.0 This dbc file seems to have been produced with a Vector tool and features EV_ (environment variables) and BA_DEF with FLOAT values. Both of which are missing in the peg parser grammar.
ev_ lines define environment variables
fixes problem described in GENIVI/CANdevStudio#196 (comment)
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not load a dbc file produced by a recent version of CANdb++ similar to the one I added to this PR due to parser errors.
This PR contains the necessary fixes to
dbc_grammar.pegalongside with a primitive test case.