-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support migrating accounts from GPO IdP to NCSA IdP #1789
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide an AJAX call to verify a username/password against an IdP. Provide a bare UI with JavaScript to enter and verify a user.
Continue the account transfer flow with a second server-side script to actually invoke the account transfer. This script must redundantly check username/password to avoid an end around by a clever user. So check again, then invoke the clearinghouse service to swap the accounts.
Invoke swap_identities after re-verifying the username and password at the IdP.
Explain to the user what they can do with the page. Caution them that they'll lose access to current projects/slices.
Conditionalize this so that it can be omitted if the user is logged in from the GPO IdP.
After redirection, display a standard "last message" telling the user that their account has been transferred.
If the destination account (currently logged in) has projects, disallow the account transfer with a message. These users must either remove themselves from the projects or manually add this account to projects of which the source account is a member.
GPO user accounts cannot be the destination of an account transfer. Prevent this by never putting the transfer button on the profile page. Further, if a GPO user manually navigates to the transfer page, redirect them to the home page. Finally, if the GPO user invokes the do-transfer script manually, return an error code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a user interface for the account transfer clearinghouse API. Verify a user at the configured IdP, then perform the account transfer.
Accounts that are members of projects are ineligible for the transfer. The transfer is a swap of the internal ID, so the user would get disconnected from their projects. This is likely to be unexpected, so simply disallow it. It should be a rare case. These individuals can either migrate project membership manually (it's not hard) or remove themselves from their current projects and do the swap.
Closes #1786