feat: 재학생 인증 여부 확인 api 구현 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwoobeat
requested changes
Feb 18, 2024
|
|
||
| public MemberUnivStatusResponse checkUnivVerificationStatus() { | ||
| Member currentMember = memberUtil.getCurrentMember(); | ||
| return new MemberUnivStatusResponse(currentMember.getUnivStatus()); |
|
|
||
| public MemberUnivStatusResponse checkUnivVerificationStatus() { | ||
| Member currentMember = memberUtil.getCurrentMember(); | ||
| return new MemberUnivStatusResponse(currentMember.getUnivStatus()); |
There was a problem hiding this comment.
Suggested change
| return new MemberUnivStatusResponse(currentMember.getUnivStatus()); | |
| return MemberUnivStatusResponse.from(currentMember); |
| @@ -33,4 +34,9 @@ public MemberInfoResponse getMemberInfo() { | |||
| Member currentMember = memberUtil.getCurrentMember(); | |||
| return MemberInfoResponse.of(currentMember); | |||
There was a problem hiding this comment.
그리고 응답 DTO 만들 때 from, of 헷갈리는 케이스 있는 것 같은데 이거 별도 이슈로 빼서 작업해주시면 좋을듯요
There was a problem hiding this comment.
급한 이슈들 먼저 처리하고 진행해볼게요👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타