Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dev 스웨거 cors에러 해결 #676

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

seulgi99
Copy link
Contributor

@seulgi99 seulgi99 commented Aug 23, 2024

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • api서버 주소가 없어서 스웨거 cors난거같네요

📝 참고사항

📚 기타

Summary by CodeRabbit

  • New Features
    • CORS 설정을 개선하여 개발 및 로컬 테스트 환경에서 허용되는 출처를 동적으로 관리할 수 있도록 변경했습니다.

@seulgi99 seulgi99 added the 🐛 bug/error 버그 및 에러 픽스 label Aug 23, 2024
@seulgi99 seulgi99 self-assigned this Aug 23, 2024
@seulgi99 seulgi99 requested a review from a team as a code owner August 23, 2024 04:17
Copy link

coderabbitai bot commented Aug 23, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

변경 사항은 CORS 구성에서 허용된 출처 패턴 처리 방식을 수정합니다. corsConfigurationSource 메서드에서, 기존의 DEV_AND_LOCAL_CLIENT_URLS에 두 개의 추가 URL(DEV_SERVER_URLLOCAL_SERVER_URL)을 포함하여 허용된 출처 목록을 동적으로 구성하도록 변경되었습니다. 이를 통해 개발 및 로컬 프로필에 맞춘 더 유연한 설정이 가능해집니다.

Changes

파일 변경 요약
src/main/java/com/gdschongik/gdsc/global/config/WebSecurityConfig.java CORS 구성에서 허용된 출처 패턴 처리를 개선, 기존 URL 목록에 추가 URL 포함.

Assessment against linked issues

Objective Addressed Explanation
스웨거 cors에러 해결 (#675)

🐇 새로운 URL로 가득 채운
CORS 설정이 더욱 뚜렷해졌네,
개발자들의 꿈을 나누며,
보안도 함께 지키는 길이네! 🌟
신나는 변화와 함께 뛰어가리!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seulgi99 seulgi99 merged commit 593413f into develop Aug 23, 2024
1 check passed
@seulgi99 seulgi99 deleted the fix/675-swagger-cors branch August 23, 2024 04:18
Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 Build Scan published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug/error 버그 및 에러 픽스
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 스웨거 cors에러 해결
1 participant