Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 과제 휴강 처리 API 추가 #542
feat: 과제 휴강 처리 API 추가 #542
Changes from 8 commits
27409b0
d75d76e
c85fc4c
d5538ea
60d880d
bac85e6
ff7411c
dac5ae8
166edd4
23603ce
151cf82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
상욱님 이거 보고 구현하다가 생각난건데
저희 이 권한 처리는 로그인과정에서 처리한다고 하지 않았나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수많은 멘토 중 해당 스터디의 멘토만 수정 가능해야 한다는 맥락에서 이런 검증을 넣었습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그리고 그냥 든 생각인데
validateCancel
validatePublish
이렇게 여러개 생성하지 말고 그냥 공통으로 쓸 수 있게 구현하는게 좋지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StudyDetail 관련된 모든 수정시
수많은 멘토 중 해당 스터디의 멘토만 수정 가능해야 한다
라는 검증을 해야할텐데,그렇다면 제가 지금 구현해둔걸 나중에 private으로 메서드로 추출해서 각 validate 메서드에서 호출하면 될 것 같습니다.
항상 검증할게 이것만 있는건 아니니까요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아아~ 알겠습니다 그럼 저도 그냥 validatePublish~~이런 메소드 저기다가 생성해서 과제 생성 api pr에 올리겠습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 메서드 추출해뒀어요.
pull 받아서 활용하시면 될 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 머지 되면 언급만 해주세용~