-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 무료 주문 생성하기 API 구현 #520
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9cb0bb1
feat: 무료 주문 생성 API 구현
uwoobeat 409b6df
feat: 오타 및 DTO 이름 수정
uwoobeat 023843f
feat: 무료 주문 생성 정적 팩토리 메서드 추가
uwoobeat 1142a54
feat: 무료 여부 확인하는 메서드 추가
uwoobeat 86584b7
refactor: 0원에 해당하는 금액 상수 추가
uwoobeat 3c5fa21
feat: 결제정보 조회 시 유료 결제만 가능하도록 수정
uwoobeat ba6ff1d
docs: 주문 취소 후 연관 엔티티 수정 작업 투두 추가
uwoobeat ce6ee9c
feat: 무료 주문 취소 불가하도록 수정
uwoobeat df2936e
feat: 무료 주문 생성 검증 로직 추가
uwoobeat f7e88f4
test: 취소 테스트 nested로 묶기
uwoobeat c3005dd
test: 무료주문 생성 테스트 추가
uwoobeat 34edf71
feat: 기존 주문 요청 DTO를 사용하도록 변경
uwoobeat 80e4447
feat: 무료주문 생성시 외부에서 금액정보 입력받도록 수정
uwoobeat 9da42f9
test: 생성자 시그니처 수정
uwoobeat 58e61de
test: 무료주문 생성 검증기 테스트 추가
uwoobeat b25c3f2
docs: 오타 수정
uwoobeat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
무료 주문이면 쿠폰이 반드시 필요한거아닌가요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
회비가 0원인 경우에는 쿠폰 없이 무료 주문이 가능하다고 봤어요
물론 회비를 무조건 양수로 지정하면 항상 쿠폰이 필요해지겠지만
쿠폰을 꼭 써야 무료 주문이다
보다는최종결제금액이 0원이면 무료 주문이다
가 더 의미적으로 적절하다고 봤습니다