Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 인증시 학교 이메일 인증 메일 전송 여부 판단 로직 추가 #513
refactor: 인증시 학교 이메일 인증 메일 전송 여부 판단 로직 추가 #513
Changes from 8 commits
7123bbf
edd5737
a6249a6
c699d39
b8d1c98
96caead
de7697e
08ba589
feacf8d
28990d5
b767e9b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적인 궁금함인데
implementation = MemberRole.class
와 같이 지정하면 어떤 효과가 있나요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
프론트에서 사용하는지는 모르겠지만, 스웨거 api 문서를 통한 api스펙 자동적용 툴들 (swagger-typescript-api, auto-generated 이런것들)사용할때 해당 객체를 �인식하게 해줘요!
저는 그냥 저렇게 항상 구현하도록 하는게 익숙해져서 그렇긴한데, 만약 안쓴다면 지워도 좋을거같아요!
어떻게생각하시나여
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 쓰는지 안쓰는지는 잘 몰라서 ㅎㅎ; 따로 요청사항 없는거 보면 안쓰는 것 같네요
일관성 측면에서 그냥 지우는게 나을듯 합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 재현님 이거는 제가 이슈파서 따로 진행하는게 좋을거같아요! 이번 pr말고도 스터디쪾도 있어서요!!