Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: admin member api 문서화 #46

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

Sangwook02
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • swagger 세팅 이전에 작업한 내용들에 설명 추가

📝 참고사항

  • 이후 작업하는 api들은 해당 브랜치에서 swagger 작업도 같이 하겠습니다.

📚 기타

@Sangwook02 Sangwook02 added the 📝 documentation 문서화 작업 label Feb 11, 2024
@Sangwook02 Sangwook02 self-assigned this Feb 11, 2024
@Sangwook02 Sangwook02 requested a review from a team as a code owner February 11, 2024 13:45
Copy link
Member

@binary-ho binary-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 너무 감사합니다!

@NotBlank @Schema(description = "이름") String name,
@NotBlank
@Pattern(regexp = PHONE, message = "전화번호는 " + PHONE + " 형식이어야 합니다.")
@Schema(description = "전화번호", pattern = PHONE)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 의견인 것 같습니다.
해당 내용은 향후 다른 issue에서 처리하도록 하겠습니다!
감사합니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아닌거 같아서 지웠는데 벌써 보셨네요 ㅠㅠ

@NotBlank @Schema(description = "이름") String name,
@NotBlank
@Pattern(regexp = PHONE, message = "전화번호는 " + PHONE + " 형식이어야 합니다.")
@Schema(description = "전화번호", pattern = PHONE)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 의견인 것 같습니다.
해당 내용은 향후 다른 issue에서 처리하도록 하겠습니다!
감사합니다!

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sangwook02 Sangwook02 merged commit 49a9575 into develop Feb 11, 2024
1 check passed
@Sangwook02 Sangwook02 deleted the docs/45-admin-member-api-documentation branch February 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 documentation 문서화 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 어드민 관련 api swagger 문서 작업
3 participants