Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: requirement 도메인 구현 #43

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

Sangwook02
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • requirement 구현
  • member 생성 시 requirement도 같이 생성하도록 수정

📝 참고사항

📚 기타

@Sangwook02 Sangwook02 added the ✨ feature 새로운 기능 추가 및 수정 label Feb 11, 2024
@Sangwook02 Sangwook02 self-assigned this Feb 11, 2024
@Sangwook02 Sangwook02 requested a review from a team as a code owner February 11, 2024 07:45
Copy link
Member

@binary-ho binary-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AllArgsConstructor
public enum RequirementStatus {
PENDING("PENDING"),
VERIFIED("VERIFIED");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가입요건의 상태들을 isUnivEmailValidated와 같은 Boolean이 아닌 Enum으로 관리하는 이유가 궁금합니다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상태는 다른 상태들이 추가될 수도 있어서 확장성을 고려해 Enum으로 넣었습니다

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sangwook02 Sangwook02 merged commit b6197e1 into develop Feb 11, 2024
1 check passed
@Sangwook02 Sangwook02 deleted the feature/42-requirement-domain branch February 11, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature 새로운 기능 추가 및 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ requirement 도메인 구현
3 participants