feat: 쿠폰 및 발급된 쿠폰 조회 API 기능 추가하기 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
seulgi99
approved these changes
Jul 1, 2024
| .orderBy(issuedCoupon.createdAt.desc()) | ||
| .fetch(); | ||
|
|
||
| JPAQuery<Long> countQuery = |
There was a problem hiding this comment.
여기서 countQuery를 써서 하는것도 좋지만, 이렇게 동일조건으로 두번 조회하면 where문에 따른 같은양의 조인이 중복적으로
발생할거같습니다.
List fetch = queryFactory. 여기 where조건에서 보시다시피 쿠폰, 멤버를 조인해야하는데
동일 조건의 아래 countquery에서도 마찬가지로 두번의 조인이 발생하니까요!
그렇다면
List<Long> ids = queryFactory.select(issuedCoupon.id).from(issuedCoupon).where(matchesQueryOption(queryOption)).fetch();
를써서 id 리스트만 받아오고 그것의 ids.size()로 카운팅을 하면 카운트쿼리가 해결되지않을까요?
그리고 이 id리스트로 실데이터 조회시엔 where(issuedCoupon.id.in(ids))로 넣으면 중복적인 조인은 발생하지 않을거에요!!
이건 성능적으로만 생각하면 되니 가볍게 봐주세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타