Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 과제 엔티티 필드 이름 수정 #416

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

AlmondBreez3
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

  • 추후 작업에 필요한 엔티티 안에 필드명 수정했습니다~

📝 참고사항

📚 기타

@AlmondBreez3 AlmondBreez3 self-assigned this Jun 25, 2024
@AlmondBreez3 AlmondBreez3 requested a review from a team as a code owner June 25, 2024 14:22
Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 Build Scan published

Copy link
Member

@Sangwook02 Sangwook02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@seulgi99 seulgi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거를 isCancelled로 두려고했는데
결국 Assignment와 Session이 StudyDetail이라는 같은 테이블에 들어가서
둘에게 모두 존재하는 휴강여부, 제목, 난이도를 똑같이 title, isCancelled, difficulty로 둘순 없겠더라구요 (db컬럼중복)
그래서 구분해뒀습니다!

그래서 그럼 클래스의 필드값은 title, isCancelled, difficulty이렇게 두되
각각

@column(name = "assignmentTitle")
@column(name = "isAssignmentCancelled")
@column(name = "assignmentDifficulty")
이렇게 지정하는건 어떨까요?

@AlmondBreez3
Copy link
Member Author

AlmondBreez3 commented Jun 26, 2024

이거를 isCancelled로 두려고했는데 결국 Assignment와 Session이 StudyDetail이라는 같은 테이블에 들어가서 둘에게 모두 존재하는 휴강여부, 제목, 난이도를 똑같이 title, isCancelled, difficulty로 둘순 없겠더라구요 (db컬럼중복) 그래서 구분해뒀습니다!

그래서 그럼 클래스의 필드값은 title, isCancelled, difficulty이렇게 두되 각각

@column(name = "assignmentTitle") @column(name = "isAssignmentCancelled") @column(name = "assignmentDifficulty") 이렇게 지정하는건 어떨까요?

네네 좋습니다
그럼 제가 지금 수정하는 겸 session도 해둘까요?

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중복 컬럼명의 경우 @AttributeOverride 를 쓰면 됩니다

Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 Build Scan published

Copy link
Contributor

@seulgi99 seulgi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다~

Copy link
Member

@uwoobeat uwoobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

수정할 부분이 있긴한데 별도 이슈로 치겠습니다

@AlmondBreez3 AlmondBreez3 merged commit 6728e7b into develop Jun 26, 2024
1 check passed
@uwoobeat uwoobeat deleted the refactor/415-study-assignment branch June 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ 스터디 과제 엔티티 필드명 수정
4 participants