feat: 온보딩 대시보드 페이지 API 구현 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Sangwook02
reviewed
Jun 20, 2024
| Optional.ofNullable(member.getDepartment()) | ||
| .map(Department::getDepartmentName) | ||
| .orElse(null), | ||
| member.getPhone(), |
There was a problem hiding this comment.
저희 원래 전화번호 xxx-xxxx-xxxx 형식으로 응답에 넣었었는데 포맷 바꾸나요?
There was a problem hiding this comment.
피그마 봤는데 대시 없어서 그냥 리턴한건데
대시 있는게 더 보기에 편하겠네요 바꿔둘게요
AlmondBreez3
approved these changes
Jun 20, 2024
| logoutAndReloginAs(1L, MemberRole.ASSOCIATE); | ||
|
|
||
| // when | ||
| var memberDashboardResponse = onboardingMemberService.getDashboard(); |
There was a problem hiding this comment.
var쓰는 건 첨 보는데 필드 추론할 때 쓰는걸로만 알고 있는데 var사용하고 정확한 필드타입 지정안해주신 이유가 따로 있나용?
궁금해서 여쭈어보는겁니당
There was a problem hiding this comment.
MemberDashboardResponse memberDashboardResponse = onboardingMemberService.getDashboard(); 가 너무 길어서 var로 바꾼건데 생각해보니 MemberDashboardResponse response = onboardingMemberService.getDashboard(); 로 하면 되겠네요. 수정할게요
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
DTO 컨벤션 추가
XXXFullDto로, 일부 필드만 대응되는 DTO의 경우XXXSimpleDto로 네이밍합니다.SimpleDto의 경우 리스트 반환 시 원본 엔티티의 필드가 너무 많은 경우에만 사용하며, 그 외에는 사용하지 않습니다.현재 열려있는 리쿠르팅 조회
isOpen으로 판단하게 했습니다.isDisplayable생기면 간단하게 변경해주시면 됩니다.OptionalOnboardingMembershipService#findMyMembership이 Optional로 리턴하도록 했습니다.테스트 변경사항
isOpen의 경우LocalDateTime.now()사용하는데 생성되는 템플릿은 과거 시점이므로 조회되지 않습니다. 이를 해결하기 위해 서비스를 모킹하여findCurrentRecruitment가 항상 템플릿 리쿠르팅을 반환하도록 만들었습니다.@MockBean의 경우 자식 테스트에 두면 해당 테스트 실행 시 컨텍스트를 재구성하므로,IntegrationTest에 위치시켰습니다. 추후 다른 로직에서 이 서비스를 사용할 경우 동일하게 모킹하여 사용해야 합니다.📝 참고사항
📚 기타