feat: 리쿠르팅에 회비와 차수 추가 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
uwoobeat
requested changes
Jun 14, 2024
| @@ -25,25 +26,42 @@ public class Recruitment extends BaseSemesterEntity { | |||
| @Embedded | |||
| private Period period; | |||
|
|
|||
| private Money fee; | |||
| } | ||
|
|
||
| public static Recruitment createRecruitment( | ||
| String name, | ||
| LocalDateTime startDate, | ||
| LocalDateTime endDate, | ||
| Integer academicYear, | ||
| SemesterType semesterType) { | ||
| SemesterType semesterType, | ||
| Money fee, |
There was a problem hiding this comment.
중요한 문제는 아니긴 한데 회차정보가 학기정보 다음에 오고, 회비는 맨 마지막에 오도록 배치하는게 낫지 않나 싶네요
| @@ -15,4 +17,6 @@ public record RecruitmentCreateRequest( | |||
| @Future @Schema(description = "모집기간 종료일", pattern = DATETIME) LocalDateTime endDate, | |||
| @NotNull(message = "학년도는 null이 될 수 없습니다.") @Schema(description = "학년도", pattern = ACADEMIC_YEAR) | |||
| Integer academicYear, | |||
| @NotNull(message = "학기는 null이 될 수 없습니다.") @Schema(description = "학기") SemesterType semesterType) {} | |||
| @NotNull(message = "학기는 null이 될 수 없습니다.") @Schema(description = "학기") SemesterType semesterType, | |||
| @NotNull(message = "회비는 null이 될 수 없습니다.") @Schema(description = "회비") Money fee, | |||
There was a problem hiding this comment.
이거 객체 취급이라서 fee.amount 이런 식으로 요청해야 할 거에요.
그냥 BigDecimal로 받아서 Money 인자로 넘겨주면 어떨까 싶네요
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
학년도, 학기, 차수가 모두 중복되는 리쿠르팅은 생성하지 못하도록 리쿠르팅 생성 Api를 수정했습니다.Recruitment.createRecruitment메서드 수정에 따른 변화입니다.📝 참고사항
📚 기타