Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 디스코드 서버 합류 여부 조회 API 구현 #368

Merged
merged 8 commits into from
Jun 15, 2024
Merged

feat: 디스코드 서버 합류 여부 조회 API 구현 #368

merged 8 commits into from
Jun 15, 2024

Conversation

uwoobeat
Copy link
Member

🌱 관련 이슈

📌 작업 내용 및 특이사항

📝 참고사항

📚 기타

@uwoobeat uwoobeat requested a review from a team as a code owner June 11, 2024 12:27
@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 ✅ Build Scan published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 ✅ Build Scan published

@uwoobeat uwoobeat self-assigned this Jun 11, 2024
Sangwook02
Sangwook02 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@Sangwook02 Sangwook02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
별개로 figma와 맞지 않는 부분이 있는 것 같아요.
중복 관련 로직은 피그마 업데이트가 안 된거니까 이렇게 구현하신거겠죠?

@uwoobeat
Copy link
Member Author

lgtm 별개로 figma와 맞지 않는 부분이 있는 것 같아요. 중복 관련 로직은 피그마 업데이트가 안 된거니까 이렇게 구현하신거겠죠?

아 프론트에서 check duplicate api를 주기적으로 요청해서 응답 상태를 받아오는 식이에요.

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 ✅ Build Scan published

@github-actions GitHub Actions
Copy link

Job Summary for Gradle

Check Style and Test to Develop :: build-test
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
gdsc check 8.5 ✅ Build Scan published

AlmondBreez3
AlmondBreez3 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@AlmondBreez3 AlmondBreez3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uwoobeat uwoobeat merged commit 09acd95 into develop Jun 15, 2024
1 check passed
@uwoobeat uwoobeat deleted the feature/358-discord-join-checker branch June 15, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlmondBreez3 AlmondBreez3 AlmondBreez3 approved these changes

@Sangwook02 Sangwook02 Sangwook02 approved these changes

@seulgi99 seulgi99 Awaiting requested review from seulgi99 seulgi99 is a code owner automatically assigned from GDSC-Hongik/backend-dev

Assignees

@uwoobeat uwoobeat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ 디스코드 서버 합류 여부 조회 API 구현
3 participants
@uwoobeat @Sangwook02 @AlmondBreez3